On 11/ 9/10 03:54 PM, Drew Fisher wrote: > Darren: > > 793: use isinstance() instead of type()
Changed, and webrev updated. > > The rest looks ok to me. Thanks for the review, Darren. > > -Drew > > On 11/9/10 8:29 AM, Darren Kenny wrote: >> Hi, >> >> I'd like to get a code review for the following webrev: >> >> http://cr.opensolaris.org/~dkenny/fix.6997925.slim/ >> >> The change made was to move from using repr() to str() for common use, and >> quotes applied manually. But, for strings, I continued to use repr() since in >> that instance the repr() function does good handling of quotes within >> strings. >> >> e.g. >> >> strings=( >> '"', >> "'", >> "abc'd", >> 'abc"d', >> "a\"b\"c'd'e" ) >> >> for s in strings: >> print "%s -> %s" % (str(s), repr(s)) >> >> gives: >> >> " -> '"' >> ' -> "'" >> abc'd -> "abc'd" >> abc"d -> 'abc"d' >> a"b"c'd'e -> 'a"b"c\'d\'e' >> >> Thanks, >> >> Darren. >> _______________________________________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
