Looks good.
Thanks!
- Keith
On 11/ 8/10 03:40 PM, John Fischer wrote:
Keith,
Thanks for clearly explaining what was needed. I truly appreciate the
help.
I have updated the webrev at:
http://cr.opensolaris.org/~johnfisc/aimdns/aimdns-6977107-3/
http://cr.opensolaris.org/~johnfisc/aimdns/aimdns-6977107-diff-3/
Thanks again,
John
On 11/ 5/10 02:51 PM, Keith Mitchell wrote:
Hi John,
[line numbers refer to the new version of the file]
In aimdns.py, on lines 619 and 736, a SystemExit is still raised.
Were you planning on changing that code now, or later? (Again, the
concern is that I don't think it's a good idea to raise a SystemExit
exception here - I don't think it's good for a class to decide
whether or not an error is completely fatal in that way)
For the atexit registration on line 1227, it should actually occur
right at the beginning of main() (around line 1183). Change on_exit to:
def on_exit():
remove_pid()
AIMDNS.clear_sdrefs()
Then, have main() return the status (either 0 or 1) and have line
1232 be:
sys.exit(main(AIMDNS))
(And remove 1233 - the idea being that, regardless of success or
failure, the atexit module will run on_exit() to cleanup)
All else looks good.
Thanks,
Keith
On 11/ 5/10 12:34 PM, John Fischer wrote:
Keith, Clay and Joe,
I have updated the webrev according to the comments received.
The new webrev is at (addresses current feedback):
http://cr.opensolaris.org/~johnfisc/aimdns/aimdns-6977107-2/
http://cr.opensolaris.org/~johnfisc/aimdns/aimdns-6977107-diff-2/
The differential webrev above is in reference to the first
revision. The
first revision is at (added in_networks functionality and appropriate
test):
http://cr.opensolaris.org/~johnfisc/aimdns/aimdns-6977107-1/
http://cr.opensolaris.org/~johnfisc/aimdns/aimdns-6977107-diff-1/
The original webrev is at:
http://cr.opensolaris.org/~johnfisc/aimdns/aimdns-6977107.orig/
Thanks for the feedback. I truly appreciate it and I think your
comments have made the tool/class better.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
