Sue,
Thanks for the review. I'll make these changes.
On 11/10/10 13:39, Sue Sohn wrote:
On 11/10/10 11:23 AM, Ethan Quach wrote:
Can I get a review for the follow two bugfixes:
BugIDs:
---------
http://monaco.sfbay.sun.com/detail.jsf?cr=6989404
http://monaco.sfbay.sun.com/detail.jsf?cr=6998468
Webrev:
----------
http://cr.opensolaris.org/~equach/webrev.6989404.6998468
Tests executed:
-------------------
Did an AI install with the updated manifest to ensure the two iscsi
packages are installed by default.
Did an AI with the new method script to ensure the error message
is no longer seen in the smf service log when debug is not enabled.
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi Ethan,
Since you're making changes to the strings in auto-installer,
I had a few nits (not your changes).
59
"only be enabled in Automated Installer environment" |
->
"only be enabled in the Automated Installer environment." |
148 Please refer to /tmp/install_log file
-> Please refer to the /tmp/install_log file
170 Automated reboot -> Auto reboot (or Automatic reboot)
I'll go with Auto reboot.
thanks,
-ethan
197 "Please refer to -> Please refer to the
209 ditto
No need to see another webrev.
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
