Hi Sue - Thanks Sue. All will be incorporated before I push. ginnie
On 11/16/10 13:05, Sue Sohn wrote:
On 11/16/10 08:50 AM, Ginnie Wray wrote: > Hi Keith and all other code reviewers - > > I went through all of the back and forth between you and Jean to > make sure I didn't miss any thing, and I thought I would use your > original to give you feedback on the overall code. I hope that makes it > easier for you to review. See below. > > I have, as well, input the comments from other reviewers. > > The final code review is posted at: > http://cr.opensolaris.org/~ginnie/trans_final2/ > > I would like to plan to putback by tomorrow, late afternoon. > > Thanks, > ginnie > Hi Ginnie, Thanks for working so hard on incorporating all of the code review comments. I have just a few left. ips.py 75 http://pkg.oracle.com/solaris/release/
ok. I'll change that.
266, 267 Better. Please add spaces so that words in exception msg arenotmungedtogether.
ok. will do.
508-512 See comments from last round (then 493-497)
sorry...I only saw the IPS. I missed the comma and space
521 add space to avoid "mustbegin" in ValueError
ok
544-548 same as above for 508-512
ok. same apology
svr4.py 390, 495 Would it be useful to include a pkg name in this exception message?
We're going to do that as an RFE.
408-409,line up under Packages, combine lines together
ok.
512-513 same thing
ok.
Thanks, Sue
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
