Overall, I'm skeptical this is worth the effort. Unless I'm missing something, even the fix is somewhat marginal to justify, as the only way this should ever occur is when run on a system that's not been updated to the current service manifests. Otherwise users have been randomly deleting service properties, and that's right in there with randomly deleting or changing permissions on files: don't do that.

Dave

On 11/17/10 04:54 PM, John Fischer wrote:
   Keith,

Probably.  But I am not sure how to test that case.  Would I get the
original properties, delete them, make the assertion and then restore
the original properties?  Or something else?

Thanks,

John

On 11/17/10 12:32 PM, Keith Mitchell wrote:
  Hi John,

Would it make sense to add an additional test case to cover this
scenario?

- Keith

On 11/17/10 11:11 AM, John Fischer wrote:
  All,

During the original code review for aimdns I removed the exception
handling for
retrieving the value of the networks SMF property.  This was in error
as shown
during testing.  I have filled the following bug:

    7000918 missing SMF property causes aimdns to fail to register
mDNS records


Please review the changes for this issue at:

     http://cr.opensolaris.org/~johnfisc/aimdns-7000918/

Thanks,

John


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to