On 11/19/10 02:48 PM, Sue Sohn wrote:
On 11/19/10 11:00 AM, joseph.vl...@oracle.com wrote:
On 11/19/10 01:38 PM, Sue Sohn wrote:
Could I please get a review of the changes for:
7001284 installadm list can have incorrect output if criteria has MIN or
MAX unbounded
Webrev:
http://cr.opensolaris.org/~sohn/7001284
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
usr/src/cmd/installadm/list.py
Issue:
------
806 # create dict from sql
807 for key in mancriteria.keys():
808 crit_dict[key] = mancriteria[key]
Why not just do
crit_dict = copy.deepcopy(mancriteria)
Issue:
------
Is the crit_dict copy of mancriteria even necessary?
Would it be possible to not create crit_dict and do:
Change from:
844 if 'MAX' + keyname not in crit_dict:
To:
844 if 'MAX' + keyname not in mancriteria:
and
Change from:
844 if 'MAX' + keyname not in crit_dict:
To:
844 if 'MAX' + keyname not in mancriteria:
or am I missing something?
Joe
Hi Joe and John,
Thanks for the review.
mancriteria is of type 'sqlite3.Row'. I was originally having an issue
testing whether a key was in mancriteria, so I converted it to a dict. I
am not seeing that issue now (maybe I originally forgot to add the
.keys()). So, I've gotten rid of crit_dict and updated the webrev.
Sue
Cool! Looks good to me now.
Joe
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
