Hi John,
Thanks for the review. I'll update the copyrights prior to the push.
- Keith
On 11/23/10 11:52 AM, John Fischer wrote:
Keith,
The changes look fine to me. However, I think you need to change the
copyright lines since you are making these changes.
Thanks,
John
On 11/23/10 11:49 AM, Keith Mitchell wrote:
On 11/23/10 11:48 AM, Shawn Walker wrote:
On 11/23/10 11:44 AM, Keith Mitchell wrote:
On 11/23/10 11:42 AM, Shawn Walker wrote:
On 11/23/10 11:36 AM, Keith Mitchell wrote:
Hi all,
Can I get a review of the following webrev:
http://cr.opensolaris.org/~kemitche/6999599/
Which addresses CRs:
6999699
<http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6999699>
Missing shebang lines in python modules leads to incorrect
dependency
generation
6988338
<http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6988338>
install/installadm has duplicate dependencies on
library/python-2/lxml-26
Since a lot of files were touched, I'll summarize the changes - all
python files in our gate that do not start with a shebang
("#!/usr/bin/python2.6") have had the shebang added. While this
change
is in conflict with
https://defect.opensolaris.org/bz/show_bug.cgi?id=11380, it is
necessary
to ensure proper dependency generation via pkgdepend. If at some
point
in time, pkgdepend does not rely on the shebang to understand that a
file is a Python module, then the shebangs could be removed for our
python files that are non-executable. (No other changes to .py files
were made in this changeset). Note that once this goes back,
slim_source
devs will need to ensure that any new Python files they add to
the gate
also have a shebang (I will send a heads-up to this effect
separately,
once this fix goes back).
If the modules in question are not executed as scripts, simply saying
'#!/usr/bin/python' should work just as well and is the preferred
method (at least the one we use for pkg(5)).
-Shawn
Shawn,
Maybe it's the short week, but I feel a little dense. Are you
saying the
lines should use "python" over "python2.6"?
Correct. pkgdepend should handle it just as well, and it's the
method we use in pkg(5) for modules that aren't ever executed as
scripts.
-Shawn
Aha, ok, that makes sense. Since slim_source has inconsistent python
shebangs anyway (hence bug 11380), I don't think that will
necessarily gain us anything immediately, but I'll go ahead and
update the files anyway. Thanks for the suggestion!
- Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
