Hi John -
I will give that a try.
thanks for the feedback.
ginnie
On 11/24/10 12:59, John Fischer wrote:
Ginnie,
The code looks syntactically correct. But will it write the output
to the logger in the case when the data does not contain
x0a or x0d?
86 tmp = str(self.data)
87 # Once the output contains a line feed or
88 # carriage return, strip it and log it
89 if '\x0a' in tmp or '\x0d' in tmp:
90 tmp = tmp.rstrip('\x0a\x0d')
91 self.trans_logger.debug('%s' % (tmp))
92 self.data = ''
Or will the data always contain that at some point in time?
Also why not put this logic in the flush and have the write simply
save the data?
Thanks,
John
On 11/24/10 11:39 AM, Ginnie Wray wrote:
Hi -
I would like to request a code review for the following:
Detailed output when reporting package transfer needed/remove unneeded
output
http://monaco.sfbay.sun.com/detail.jsf?cr=7001612
Webrev is located at:
http://cr.opensolaris.org/~ginnie/7001612/
I tested slim_source nose tests and also ran those in the cud_dc gate
for dc.
thanks
ginnie
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
