Hi Matt.
Thanks for doing this work. Here are my comments:
parser.py:
106-107: I would remove comment about DerivedManifest using this. IMHO
users of a method shouldn't be listed in the method's comments, as the
comment can sneakily go out of date.
Consider putting 393-398 under the if of 390. No need to continuously
check that the manifest exists and is a file after doing it once.
428: I think can_handle() has to return False instead of None here.
While None may work, I see the DOC calls it and expects a boolean.
(lib/install_doc/data_object/cache.py line 349). That same file also
implements a can_handle() method which does the same as yours, and
returns False for the same reason
that ManifestParseData's returns None:
def can_handle(cls, xml_node):
'''The DataObjectCache class doesn't import any XML itself.'''
return False
The other files look fine.
Thanks,
Jack
On 12/15/10 09:32 AM, Matt Keenan wrote:
Hi,
I'd like a couple of pair's of eyes to scan over a fix for bug :
7004864 Read profile to be parsed from DOC if not specified via
arguments
http://monaco.sfbay.sun.com/detail.jsf?cr=7004864
Webrev ;
http://cr.opensolaris.org/~mattman/bug-7004864/
This request modifies Manifest Parser so that a manifest being passed
at initialization is not a hard requirement. If not passed it will be
read from a location in the Data object Cache. This functionality is
being added to support Derived Manifests.
cheers
Matt
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
