John,
The changes look fine to me. Thanks for retesting it.
-ethan
On 12/20/10 11:22, John Fischer wrote:
Keith,
Ethan and I noticed a slight problem with the service method refresh.
It was not doing the kill correctly for apache. apacheclt has a restart
function which fits our needs. So I have updated the webrev at:
http://cr.opensolaris.org/~johnfisc/aimdns-7007574-diff-3/
http://cr.opensolaris.org/~johnfisc/aimdns-7007574-3/
Please let me know if you are good with this additional 1 line change.
Thanks,
John
On 12/20/10 09:14 AM, Keith Mitchell wrote:
Hi John,
This looks good to me.
- Keith
On 12/17/10 08:25 PM, John Fischer wrote:
All,
During testing the original fix was found to be lacking. The webrev
for
the new fix can be found at:
http://cr.opensolaris.org/~johnfisc/aimdns-7007574-2/
We, Ethan (who was totally awesome) and I, found that the cherrypy
webserver was not able to handle the SIGHUP being sent from the
SMF service method. Additionally, I made a change to process the
aimdns find requests differently. The tool used to use the browse
method to find a list of services and then filter for the specified
service. Now it uses DNSServiceResolve to find the desired service.
This gives us a huge performance boost within the find code.
Ethan did a bunch of testing (create-service, delete-service,
enable, disable, reboot, ...) to ensure that the solution was working
as expected for the 91 services on osol-inst.
Thanks for the review,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
