On 12/20/10 11:35 AM, Ethan Quach wrote:
Sue,
The changes look OK to me. Just a couple of questions/comment...
AI_database.py
--------------------
450 - If build_query_str() couldn't generate a query string, should we return an
error here instead of 0 ?
This is actually the same operation as the code before the changes. Before,
findManifest would return a 0 on line 495 if there was a KeyError. In the new
code, that same KeyError is now generated in build_query_str. In that case, a 0
is returned from build_query_str and findManifest returns a 0, just as before.
471 - It's not exactly clear to me from this comment what this achieves. After
line 474, could you perhaps add a line stating "This allows for criteria that
can be ranges or exact values to be weighted equally during the ORDERing process
for manifests that have that criteria set."
Will do.
526 - Should this still need to be in an else: ?
The else clause on a for loop is executed unless a break terminates the for
loop. Since there are no break statements in the loop, the else wasn't necessary
so I removed it.
Thanks for the review,
Sue
thanks,
-ethan
On 12/17/10 09:37, Sue Sohn wrote:
I've updated the webrev. Please review at link below.
Thanks,
Sue
On 12/14/10 09:33 AM, Sue Sohn wrote:
Please hold up on this code review. I'm looking into an edge case that might
change the algorithm.
Thanks,
Sue
On 12/13/10 09:23 AM, Sue Sohn wrote:
Could I please get a review of the changes for:
6973601 problem on the criteria matching algorithm in AI install service
10073 installadm man page hints at support for remote DHCP system
Webrev:
http://cr.opensolaris.org/~sohn/6973601
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
