Hi everyone.
Review at original link updated to improve logging and error/warning output.
Note: any new changes will be made in a separate area.
Thanks,
Jack
On 12/26/10 21:53, Jack Schwartz wrote:
Hi everyone.
Here is a work-in-progress code review for the Derived Manifests
project Manifest Input module and aimanifest command. I am exposing
these files to the team, to make sure there are no glaring omissions,
or feasible but overlooked improved ways of implementation.
Files are commented and are fairly clean, but will be tweaked somewhat
before push. (Please ignore, for example, the hardwired references to
personal files which will be removed.)
Since people may be out on vacation this week, I prefer
comments/questions by Weds 1/5.
http://cr.opensolaris.org/~schwartz/101226.1/webrev
If you would like a personal tour to help you review, please let me know.
Read on if you want details on what these files are for:
The Manifest Input module manipulates XML data by:
- adding new single elements or changing values of
existing single elements.
- adding a new attribute to an element, or changing
the value of an existing attribute.
- overlaying a tree of XML data on top of another
tree of XML data.
- retrieve the value of an XML element or attribute.
- load / validate / write the in-memory data tree.
The aimanifest command is a CLI which operates the Manifest Input
module. The Derived Manifest Module checkpoint will call a script
that invokes aimanifest to customize a manifest for a specific system.
Usage:
aimanifest subcommand cmd_options
subcommands:
aimanifest set [-r] <path> <value> Change value or add/change
attributes"
aimanifest add [-r] <path> <value> Add new element"
aimanifest get [-r] <path> Retrieve element value or
attributes"
aimanifest load [-i] <filename> Load / incrementally overlay
XML file"
aimanifest validate Validate XML data"
aimanifest commit Write XML data"
The -r option to set/add/get displays the path of the returned
element
in terms of node IDs. This path may be used in subsequent calls to
aimanifest to specify the affected element more directly.
Thanks,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
