On 12/21/10 08:32 AM, William Schumann wrote:
Requesting code review for enhancements for service configuration profiles in
the Automated Installer.
http://cr.opensolaris.org/~wmsch/profile/
The code can be divided into sections:
UI - installadm invokes UI, modifications in database routines, since profiles
are now in a separate table.
CGI - runs under AI image-server under Apache, locate_profile, ai-httpd.conf
AI client - modifications to ai_get_manifest, manifest-locator,
auto-install.c/h, ict.py
package modifications for new PY modules, CGI script: install-installadm.mf
automated tests
Modified AI_database.py to allow many functions to specify database table.
Should default to 'manifest'. Changed AI_database.py message output to stderr,
which becomes significant for CGIs, where stderr goes to the error log and
stdout should be only for intended output so that message header output is
properly sequenced. Tried to fix a problem that appears when there is no
criteria in the manifest database in build_query_str().
Design document:
http://hub.opensolaris.org/bin/download/Project+caiman/System+Configuration+Project/SCProfileProposal.odt
Authentication and user-defined scripting not supported in this release.
Decided to back out support for XInclude for the time being, problem being that
our best attempt at specifying when and if XInclusions are to occur depends on
modifications to service_bundle(4) DTD, and it still needs approval by SMF. Some
artifacts of this support remain in the source, since approval is expected.
Have done unit testing on AI microroot, but have not built or tested
auto-install image. Will do so next, in concurrence with code review.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi William,
I started looking through the review and noticed that you are adding a new
subcommand, set-profile. Wasn't the plan for you to use set-criteria and add
support for profiles with "-p <profile_name>"?
Also, validate-profile and export-profile are supposed to be called validate and
export per email I sent previously (and per discussions we've had with Ethan).
One more thing - you'll need to update the installadm man page and include that
file in your webrev. I will send you something offline which you can use as a
starting point.
I'll send actual code review comments later.
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
