On 01/ 7/11 10:44 AM, Dave Miner wrote:
On 01/ 6/11 06:57 PM, Keith Mitchell wrote:
This might help:
http://cr.opensolaris.org/~kemitche/6971585.final/
pkg_img_mod.py, 436: s/after to/after the/
Fixed.
net-fs-root
219: this comment seems wrong, and probably should be the same as the
comment at 171, since it's the same effect
Fixed.
408: I don't get why we're doing a refresh after enabling the service.
If the refresh is necessary at all (which I doubt, since there's
nothing here that modifies that service's configuration) it seems that
it should be prior to the enable.
Yes, that's not necessary. I've removed it.
ict.py, 1561: should we be logging a warning here?
A debug message for now, perhaps. When this ICT transitions to a
checkpoint, perhaps the control can be finer grained so that pkg_list
doesn't contain packages that aren't already installed.
Updated webrev: http://cr.opensolaris.org/~kemitche/6971585.final.2/
- Keith
Dave
On 01/ 6/11 03:56 PM, Keith Mitchell wrote:
Hi,
Can I get one or two sets of eyes to look at (what I hope to be) the
last webrev for netboot text installer? This work was started by
Andrew and Chris last fall, and I've merged it with the updated DC, as
well as ironed out a few last minute bugs (plus tossed in a fix to
7010312 for good measure).
The files that have changed since last are:
grub_setup.py
pkg_img_mod.py
net-fs-root
ti_install.py
Though comments on the other files are of course welcome as well.
Thanks,
Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
