On 01/10/11 11:36 AM, Jack Schwartz wrote:
Hi Alok.
The changed manifest line has "2008" in it. Does it need to be changed
to "2011"? (I'm not sure as I don't really know what it represents,
but I'd be suspicious...)
2008 is correct. It's an IPS thing.
I agree with Karen, that cmd needs to be converted to a string. Maybe
use join as on 493 and 526?
+1 to using " ".join(cmd) for better readability of the output.
The rest looks fine to me.
Thanks,
Jack
On 01/10/11 10:50 AM, Alok Aggarwal wrote:
Could I please get a couple of reviews for:
7010847 install/distribution-constructor could use a better
classification value
7011031 pre-pkg-img-mod does not abort processing when certain errors
occur
Webrev:
http://cr.opensolaris.org/~aalok/7010847-7011031/
I'd like to get these into slim_source over the next
couple of hours so a quick review would be appreciated.
Thanks,
Alok
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
