Hi John,
On Thu, 13 Jan 2011, John Fischer wrote:
Alok,
I am not 100% sure. However, I thought that other images might
want to version various components. Thus I put it into PrePkgImgMod
class. It could go in the AIPrePkgImgMod class until such time as
another image type needs or wants to version components. Is that
you suggestion?
Yes, please move it to AIPrePkgImgMod since only AI uses it right
now.
Here are my comments for pre_pkg_img_mod.py, I looked at that file
only:
230: Why change the mode to 'a'? I think we want to truncate
that file if it exists.
227, 238: Since both these functions need this path it should
probably be moved up to the parse_doc function above around
line 99.
241, 244, 247, 254: These try/excepts are not needed. The build
will continue even in the case of errors with these try/excepts
in place.
250-253: Nit. This may be simplified as:
for line in img_fh.readlines():
img_fh.write(line)
Alok
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
