On 01/20/11 03:09 PM, Karen Tung wrote:
On 01/20/11 14:29, Keith Mitchell wrote:
All,
I have a small code review for the following bugs:
7013717 /etc/system not handled correctly for SPARC when using
network text install
7013382 test_i18n.py sometimes fails in tearDown
Webrev:
http://cr.opensolaris.org/~kemitche/webrev.7013717/
In the case of the former, I missed a small but important line change
to pre_pkg_img_mod.py in my commit. For the latter, in some locale
situations (most notably, the set-up used by our build machines), the
tearDown() method's call to setlocale() would fail, causing the tests
to appear to have failed.
- Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi Keith,
The code changes look good to me.
However, for completeness, you should update the evaluation of bug
7013717.
Dave has a comment in the evaluation section suggesting to
move the modification of /etc/system that's done in
boot_archive_archive to pre_pkg_img_mod.
Your fix didn't implement that suggestion. I think you need to update
the bug
and discuss why you didn't implement that suggestion so the bug will have
complete information.
Thanks,
--Karen
I've updated the bug evaluation to explain why the logic can't be moved
fully out of boot_archive_archive.
Thanks for the review!
- Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
