On 01/24/11 03:06 PM, Karen Tung wrote:
 On 01/24/11 14:46, Keith Mitchell wrote:
All,

I'd like to request a review of my changes to fix CR 7014370.

webrev:
http://cr.opensolaris.org/~kemitche/webrev.7014370

As we don't now and never have used the "install-extra" repo concept, I've elected to remove those files and lines dealing with it.

- Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Hi Keith,

The files usr/src/pkg/transforms/synthetic and usr/src/pkg/README.pkg
have something related to the install_extra package and repo, do those files
need to be updated as well?

Hi Karen,

I'll file a separate bug to update those files, though in both cases it's harmless references.


While completely removing the install-extra package and repo works for solving the problem for now, do you know why we suddenly have this problem of delivering the install-extra package into install-nightly? The install-extra package and install-extra repo have existed since we convert the gate to building IPS packages. Why was it not a problem before? I understand that you want to fix the problem quickly now so RE can start the build, but I think it will be worthwhile to figure out exactly why things
are happening for the long run...

There was an issue of some kind with my push for CR 7011710 (usr/src/pkg/Makefile should be updated to be louder on failures). As you note, I wanted to turn this CR around quickly so RE could get the build started; faced with the choice of digging through Makefile syntax to figure out how to make things work with install-extra, or removing install-extra, given our lack of use of install-extra, I went with the removal. I agree that it would be nice to understand the exact reasons why the changes in CR 7011710 led to this condition, and will also file a CR to re-evaluate further.

- Keith


Thanks,

--Karen

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to