Hi all,
I'd like a code review for my fixes for:
15957 <http://defect.opensolaris.org/bz/show_bug.cgi?id=15957> Implement
solaris_install.Popen
7014402
<http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7014402> SUNW*
packages showing up in install-redistributable
webrev:
http://cr.opensolaris.org/~kemitche/webrev.15957/
Notes:
* solaris_install.Popen is a drop-in replacement for subprocess.Popen -
as verification, the test code actually runs the full subprocess.Popen
test suite against solaris_install.Popen.
* "exec_cmd" and its family have not yet been removed. I will file bugs
against the various installers to replace usage of such functions with
solaris_install.Popen invocations; this allows for new consumers to use
solaris_install.Popen now, rather than waiting an indefinite amount of
time for me (or someone) to pull out those functions and widely re-test
a large portion of the slim_source codebase.
* I initially considered doing a global find/replace of subprocess.Popen
with solaris_install.Popen. However, since solaris_install.Popen is in
the solaris_install module, in many cases that results in a new Python
import of a module not in the Python standard library. This has
potential implications on packaging dependencies; as such, there are
risk and time factors involved in such a find/replace (in the form of at
least sanity checking most installers). As there will be bugs to remove
"exec_cmd" functions anyway, it seems appropriate to have those bugs
also replace subprocess.Popen with solaris_install.Popen. (The current
approach also is probably easier for the various projects to merge with)
Thanks,
Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
