Sue,
installadm.py
remove spaces after [, { and before ],} - line 139, 210, elsewhere
Is --debug option forwarded to subcommands?
53: this value should be commented and a symbolic value used if available
85: use Args:/Raises: standard for commenting
92-6: please explain in comments
98: logging should go to stderr in principle, not stdout, since some installadm subcommands have output that can be handled or
redirected independently: e.g., export.
170: can only root do this service management? Couldn't some other user who had user profile settings of 'primary administrator',
for example, do this?
199 repeated usage of 'status' as a constant string suggests a symbolic value
be used instead and perhaps have a comment with it
277: explain what this does in comments
296: what will happen if two different subcommands on the command line?
Shouldn't the subcommand always be in argv[1]?
I'll continue to look at other modules.
William
On 01/28/11 07:57 PM, Sue Sohn wrote:
Could I please get a review of the changes for:
7015429 Convert installadm.c to python
Webrev:
http://cr.opensolaris.org/~sohn/7015429
We can thank Joe for some of this code, since he began the conversion effort as
part of the ISIM project.
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
