On 02/ 4/11 10:14 AM, John Fischer wrote:
Keith,
I corrected these issues. Re-ran pep8 which is now clear.
These issues were because I had an older version of the list.py
file pre-merge for the AI webserver design project. They
are all corrected:
http://cr.opensolaris.org/~johnfisc/7013975-list-sparc-clients-2/
http://cr.opensolaris.org/~johnfisc/7013975-list-sparc-clients-diff-2/
I'll be sure to double check the merge first next time.
Sorry.
No worries. PEP-8 isn't worth getting too trussed up over!
And LGTM.
- Keith
John
On 02/ 4/11 09:53 AM, Keith Mitchell wrote:
Hi John,
Some PEP-8 nits below. Content-wise, I see no issues.
304: Should have spaces around the '+'. If you need to wrap the line,
wrap after the comma, like so:
compatibility_path = os.path.join('/etc/netboot',
ipaddr[:end] + '.0')
307: Should be no spaces between the brackets and the items, i.e.:
[compatibility_path, '/etc/netboot']
329: Should be spaces around the colons.
330: As Ethan noted, the original form is actually the preferred
method for checking if a dictionary has a key.
- Keith
On 02/ 2/11 10:39 AM, John Fischer wrote:
All,
During the AI webserver design project QE noticed a bug within
installadm list
not listing SPARC clients. This is because the multi-homed project
changed how
the client information was stored within /etc/netboot. The
following webrev
addresses the issue:
http://cr.opensolaris.org/~johnfisc/7013975-list-sparc-clients/
Mary has been using this version of installadm list to verify the
clients on
systems that have been updated to multi-homed and AI webserver design
projects.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
