> Dave, > > On 02/04/11 16:28, Dave Miner wrote: > > On 02/ 4/11 06:47 AM, Dermot McCluskey wrote: > >> Niall, > >> > >> Is there a file that defines all the supported > GUIDs? > >> /usr/include/sys/efi_partition.h seems to have at > least the Solaris > >> value you are defaulting to. > >> > >> My preference would be to either require the user > to enter the guid > >> hex string, but refer them to a local file that > defines all the > >> supported > >> values (in which case I call the attrib "guid", > not "guid_type"? > >> > >> or switch to using meaning names, but have a list > of the supported > >> values hard-coded in the DTD, eg: > >> <!ATTLIST gpt_slice gpt_partition_type > (solaris|esp|....) > >> "solaris"> > >> plus a comment that explains that these values are > mapped to GUIDs > >> internally. > >> > > > > I think that's unnecessarily restrictive. New > types are liable to be > > defined from time to time, and allowing GUIDs as a > fallback when we > > have not defined a token (we may also not care to > bother defining > > tokens for all possible usages) seems to have > little cost and gain > > flexibility and robustness[1]. > > Ok - so you're suggesting that the same attrib can > take either guid > values or "human-readable" names, in the same way > that part_type > can be either "191" or "Solaris2"? > > I'm fine with that, but I would really like there to > be a comment > explaining this and, if possible, a reference to > where the list of > supported values can be found.
I agree also that it should be commented and provide a reference. I just wanted to get a consensus and it seems the initial proposal is acceptable. I'll merge it in with the target.dtd, add comments and send out for another inspection. Niall > > - Dermot > > > > > > Dave > > > > [1] > http://en.wikipedia.org/wiki/Robustness_principle > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-di > scuss > -- This message posted from opensolaris.org _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
