Thank you, Evan :-)
Jan

On 02/11/11 05:47 PM, Evan Layton wrote:
looks good to me. Nicely done. :)

-evan

On 2/11/11 5:30 AM, Jan Damborsky wrote:
Thank you very much for review, Dave.

I have incorporated all your comments - updated full
and incremental webrevs are available at:

http://cr.opensolaris.org/~dambi/sc-7012389-cr/
http://cr.opensolaris.org/~dambi/sc-7012389-cr-diff/

I went with '/system/volatile' as a temp directory, so I will
retest against 159 once available.

Jan


On 02/10/11 09:40 PM, Dave Miner wrote:
On 02/10/11 10:11 AM, Jan Damborsky wrote:
Hi Jean,

could you please review changes for following CR and
verify they satisfy unconfig requirements ?

7012389 Modify svc:/system/install/config to satisfy needs of
'unconfiguration'

webrev:
http://cr.opensolaris.org/~dambi/sc-7012389/


A couple of things in svc-system-config:

- We should be using /var/run (/system/volatile) rather than /tmp for the tmp
files

992: "required"

1005: "uncomment"

1008: I wouldn't be printing this, at least the CR portion

1033: "prematurely"

Dave

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to