John,
I have similar thoughts as Ethan, but further, I guess specifically I have
these questions:
544-550:
- Would it not be better/cleaner to be explicit with the 4 conditions rather
than implicitly leaving the 2 out based on pre-existing values/assumptions?
- Specifically on the else (line 549): what cases does this cover? Are the only
2 cases the only ones we need them to be excluded?
- Any reason for not using include_it=true first, then flipping it to false for
the 2 later cases?
Thanks,
Martin
On 2/15/2011 6:10 PM, Ethan Quach wrote:
John,
544-550 - does this logic account for the fact that if exclude_network ==
false, and networks == 0.0.0.0/0, (these are the default values) then we really
want to include all of the systems networks? This block comment above at
528-539 does not indicate that.
544 - for the case where networks == 0.0.0.0/0, is self.networks None here or
will we enter this if clause?
806-812 - For browse, why do we need to ask the SMF service for the number of
install services that are configured on the local system? Browse, is supposed
to be an outward looking query, so the number of services we have configured on
the running host seems irrelevant.
-ethan
On 02/15/11 15:09, John Fischer wrote:
All,
Let's try that again.
The webrev is located at:
http://cr.opensolaris.org/~johnfisc/7019724-aimdns/
Thanks Mary and Drew for jumping on that quickly.
John
On 02/15/11 03:02 PM, John Fischer wrote:
All,
Here is a webrev for CR 7019724:
http://monaco.sfbay.sun.com/detail.jsf?cr=7019724
The webrev is located at:
http://monaco.sfbay.sun.com/detail.jsf?cr=7019724
During tests of the webserver project the clients contained the
installadm package and thus had access to the install/server SMF
service information. So what happened is when the webserver package
bug (CR 7018370) removed a dependency on installadm the
client no longer had access to the install/server SMF service information.
This meant that the client would try to get the all_services properties
and fail. Thus the install would stop. However, the client does not
need to have those properties. So the solution is to move the initialization
of the properties into the register portion of the code which is done on
the server side of the house that has access to the appropriate
install/server SMF service information.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
