On 02/16/11 07:44 AM, William Schumann wrote:
Keith,
On 02/ 4/11 07:32 PM, Keith Mitchell wrote:
I didn't do a full review of your changes, though I can if you'd
like. I have one comment on the file structure. I think that
"common_profile" should just be named "profile" - the 'common' aspect
is sort of implied by the fact that it's an importable module.
installadm_common.py set a standard for that usage, and it seems to be
a throwback to the <task>_api.h de facto standard for 'C'. I guess I
still find it useful to be explicit here. 'common' tells the casual
reader immediately that it isn't the main module.
FYI:
current webrev: http://cr.opensolaris.org/~wmsch/profile3/
Thank you,
William
Hi William,
I plan on trying to migrate installadm_common.py into
osol_install/auto_install/__init__.py as a part of the ISIM work, in
case that helps change your mind. Overall though it's not too big a
deal, it just happens to be a peeve of mine.
- Keith
- Keith
On 01/26/11 06:18 AM, William Schumann wrote:
Submitting for a second review at
http://cr.opensolaris.org/~wmsch/profile2/
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
