Argh.. thanks Evan.
I am used to having the src control (ADE) to do that for me...
Martin
On 2/17/2011 3:01 PM, Evan Layton wrote:
The copyright needs to be updated but other than that it looks fine.
-evan
On 2/17/11 3:45 PM, Martin Widjaja wrote:
It's updated in case anyone wants to re-review..
Martin
On 2/17/2011 2:25 PM, Martin Widjaja wrote:
Keith - Thanks.
I got similar response from Seth separately (Thanks!).
I think somehow I messed up this hg or webrev stuff. I went through several
iteration with webrev and had to redo same changes in my repos cause my host
is giving me issues with generated ssh key since I am using a host that's not
lookup-able. it shouldn't show as being deleted. I'll repost.
Thanks,
Martin
On 2/17/2011 2:05 PM, Keith Mitchell wrote:
On 02/17/11 01:35 PM, Martin Widjaja wrote:
All,
If someone can just review this simple fix and make sure I am not messing
anything up in my first hg run here, that'd be great.
In the mean time I'll run logger unit tests.
Bug: http://monaco.sfbay.sun.com/detail.jsf?cr=7012566
webrev: http://cr.opensolaris.org/~widjaja/bugfix-7012566/
<http://cr.opensolaris.org/%7Ewidjaja/bugfix-7012566/>
Thanks,
Martin
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi Martin,
I think you'll want the line to be:
close_log_list = []
Or else you'll find line 293-294 of the code to fail.
- Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
