Following is the review for chunk c. Most of it is nits, only a few
real questions/concerns. Nice code to read and understand in general.
usr/src/lib/install_target/shadow/Makefile
Copyright should be 2011
usr/src/lib/install_target/shadow/__init__.py
Very nice block comment at the top. The code maintainers will thank you.
Does something like append work? If not, is it worth adding?
usr/src/lib/insall_target/shadow/shadow_logical.py
line 58: I think it would be nice to put a comment at the top of insert
explaining the exact validation conditions that are addressed.
usr/src/lib/install_target/shadow/shadow_physical.py
lines 139, 255: I think it would be nice to put a comment at the top of
insert explaining the exact validation conditions that are addressed.
line 196: The comment mentions slice 2, but what does the hasattr check for?
line 223-227: Is what you're doing here really checking that the slice
doesn't run off the end of it's parent? If so, the comment is
misleading. If not, what are you doing?
line 234, 245: s/continer/container
line 273: It would be better to use the #define name instead of 15
here and in the following code.
If i remember correctly from the extended partitions project, 15 isn't
the only valid value here. Ginnie, William, or Matt should know for sure.
line 302: s/inserted/insert
Jean
b) Target Instantiation
c) Target controller API and target validation
d) ctypes interfaces
e) Other
Webrev location:
http://cr.opensolaris.org/~aalok/cud_ti/
Please let us know which of the above sections you'd like to
sign up for, an approximate list of files corresponding to each of
the review sections is included below for your convenience.
We would like your comments back by March 10.
Thanks,
Drew, Alok (and Jean)
(a) usr/src/lib/install_target/td.py
usr/src/lib/install_target/test_td.py
usr/src/lib/install_target/vdevs.py
usr/src/lib/install_target/size.py
usr/src/lib/install_target/test/test_zpool_vdevs.py
b) usr/src/lib/install_target/ti.py
usr/src/lib/install_target/physical.py
usr/src/lib/install_target/logical.py
usr/src/lib/install_target/test/test_target_instantiation.py
usr/src/lib/install_target/test/ti_full.py
c) usr/src/lib/install_target/shadow/*
usr/src/lib/install_target/test/test_shadow_list.py
d) usr/src/lib/install_target/libadm/*
usr/src/lib/install_target/libbe/*
usr/src/lib/install_target/libdevinfo/*
usr/src/lib/install_target/libdiskmgt/*
usr/src/lib/install_target/libnvpair/*
e) Makefiles, DC changes, MP test changes, engine and
errorsvc changes, packaging
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
