Retrying since it bounced the first time. -Sanjay
-------- Original Message -------- Subject: Re: [caiman-discuss] Code Review ICT -> CUD Conversion Round 2 Date: Mon, 28 Feb 2011 17:02:10 -0700 From: sanjay nadkarni <[email protected]> To: [email protected] __init__.py: 29: remove ".py" in "cleanup_cpio_install.py" cleanup_cpio_install.py: 156-168 and 170-181 appear to almost repeat. Could this be instead a method ? initialize_smf.py: 71: Can you please add a comment that GLOBAL_DB will be removed soon and when that is done, we will need to remove this line. I have not looked at the test but that that's it for now. -Sanjay On 02/22/11 01:08 PM, Virginia Wray wrote:
Thanks for the feedback everyone. I have applied the comments, and posted a second webrev. Here is the original webrev: http://cr.opensolaris.org/~ginnie/icts/ Here is a webrev diffed with the original webrev: http://cr.opensolaris.org/~ginnie/ict2_diff1/ And here is a clean second webrev: http://cr.opensolaris.org/~ginnie/ict2/ Some comments about the changes: I removed the apply_sysconfig checkpoint (and tests) for review at this time. There are some other changes happening that will affect this ict, so I'll incorporate it later. I didn't remove it from the Makefile or the __init__.py because it will still be used in the cud_ti gate as is. This code is only going into cud_ti, so it won't cause any problems for slim_source. Matt asked me to create a separate checkpoint for the flush-contents_cache functionality. That's been added as the ips checkpoint and removed from the cleanup_cpio_install checkpoint. The IPS API is now being utilized in cleanup_cpio_install code. I added common code into the __init__.py for the checkpoints and created common_create_simple_doc for duplicative code used by the tests. I ran the nose tests in the cut_ti gate with the following results. The cleanup _cpio_install is low due to the fact that the dry_run path excludes all of the actual IPS execution. I followed the precedent set in transfer in creating these tests. All of the tests fail in the slim_source gate due to relying on modules that are currently only found in cud_ti. solaris_install.ict 56 55 98% 128 solaris_install.ict.boot_archive 15 14 93% 70 solaris_install.ict.cleanup_cpio_install 149 84 56% 127-129, 135-137, 142-153, 163, 168, 177, 181, 193-194, 200-204, 211-219, 231-255, 261-304, 311-312, 320-321 solaris_install.ict.create_snapshot 18 17 94% 81 solaris_install.ict.device_config 11 9 81% 67-68 solaris_install.ict.generate_sc_profile 64 54 84% 86-88, 142, 162-169 solaris_install.ict.initialize_smf 24 24 100% solaris_install.ict.update_dumpadm 23 19 82% Please have comments to me by COB Monday, Feb. 28. Thanks, ginnie _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
