Looks fine, Jan.
Dave
On 02/25/11 03:29 AM, Jan Damborsky wrote:
Hi Jack,
thank you very much for review.
I have incorporated all your comments - updated diff and full webrevs
can be looked at:
http://cr.opensolaris.org/~dambi/ns-6998550-5549-cr-diff/
http://cr.opensolaris.org/~dambi/ns-6998550-5549-cr/
I also finished the rest of the tests:
* x86 GUI installation
* Sparc media text installation& AI
They all succeeded.
Jan
On 02/24/11 06:29 PM, Jack Schwartz wrote:
Hi Jan.
Looks pretty good... A few comments:
ict.py: nit: 965: Would it be more maintainable to instead say
something like "build out sc_profile from template" instead of
mentioning specific things like DNS, which are not tweaked by this
routine at all? If the sc_template is later changed, who will
remember to change the comment in this file as well?
perform_slim_install: 1992: A check of the slim_source gate shows that
the sys_config struct is used only by this file. It can be removed
from usr/src/lib/liborchestrator/orchestrator_private.h
Thanks,
Jack
On 02/24/11 08:13 AM, Jan Damborsky wrote:
Hi all,
I would appreciate review of changes for following CRs:
5549 sysidtool(1M) and sys-unconfig(1M) should be removed from
installers
6998550 AI needs a way to specify NIS or LDAP name service
Overview:
Those changes modify AI to be able to support configuring other than
DNS naming service in SC manifest once it is possible to do that
via smf properties (after CR6959149 is fixed).
webrev:
http://cr.opensolaris.org/~dambi/ns-6998550-5549/
Thank you,
Jan
Tests accomplished:
- x86 text install and AI images based on 159 built
- text installation and AI tested with those images
- before reboot, it was verified that
- following files are no longer created on target:
/etc/.UNCONFIGURED, /etc/.sysidconfig.apps, /etc/.sysIDtool.state
- on installed system, it was verified that
- DNS works as expected (for AI, default AI manifest was used)
- x86 GUI and Sparc tests are ongoing.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
