We're approaching the finish line with the phase two of the
JumpStart to AI translation utility (js2ai) and we're looking for
some folks to take a look at the code. We would like to get any
review feedback by next Tuesday March 8th.
Webrev:
http://anthrax.us.oracle.com/net/dv31.us.oracle.com/nfs1/ws/evanl/js2ai-child/webrev/
For the man page at usr/src/man/js2ai.1.txt the file still needs
some formatting help but since its pretty much been rewritten for
phase two so we would like to get some comments on content. Once
we have that we'll pass it off to the man page folks to get some
help with formatting.
The bug list in the commit comments encompass the phase two changes.
These include support for translating sysidcfg to the SC xml
section of a manifest as well as the validation of the generated
manifest using the ManifestParser. Also included are fixes for
various items found in testing.
Unit testing code coverage results:
Name Stmts Exec Cover Missing
-------------------------------------------------------------------
solaris_install.js2ai 672 556 82% ...
solaris_install.js2ai.common 197 152 77% ...
solaris_install.js2ai.conv 757 618 81% ...
solaris_install.js2ai.conv_sysidcfg 486 453 93% ...
solaris_install.js2ai.default_xml 74 58 78% ...
solaris_install.js2ai.ip_address 61 52 85% ...
-------------------------------------------------------------------
TOTAL 2247 1889 84%
----------------------------------------------------------------------
Note: I removed the line numbers from the coverage output for
readability.
This code does not take into account the new target DTD and schema
as this is not yet available. We have filed a bug (CR 7021883) to
cover this when the new target DTD is available. We plan to make
these changes and test with this as part of the cud_ti set of changes.
We had a very brief pre-review to do a quick sanity check. I wanted
to thank those that helped with this pre-review. If anyone is
interested I can generate intermediate diffs for this but it's
pretty minor.
Please me sure to include Kristina in your responses since she is
not on the caiman-discuss alias.
Thanks!
-evan
====================================================================
I've also included a bit more information showing examples of output
from the command.
Verbose output -
# js2ai -v -r -d
/net/dv31.us.oracle.com/nfs1/ws/evanl/playground/stuff/jump -D
/tmp/jump
Processing: rules
Processing profile: upgrade
Processing profile: x86-class
Processing profile: crap1
Processing profile: my_profile
Processing profile: my_stuff
Performing conversion on: rules
Generating criteria data for: upgrade
Performing conversion on: upgrade
Generating manifest for : upgrade
Validating manifest upgrade.xml
Generating criteria data for: x86-class
Performing conversion on: x86-class
Generating manifest for : x86-class
Validating manifest x86-class.xml
Generating criteria data for: crap1
Performing conversion on: crap1
Generating manifest for : crap1
Validating manifest crap1.xml
Generating criteria data for: my_profile
Performing conversion on: my_profile
Generating manifest for : my_profile
Validating manifest my_profile.xml
Generating criteria data for: my_stuff
Performing conversion on: my_stuff
Generating manifest for : my_stuff
Validating manifest my_stuff.xml
Process Unsupported Conversion Validation
Name Errors Items Errors Errors
------------------- ------------ ------------ ------------ ------------
rules 1 5 0 -
crap1 0 0 0 5
my_profile 0 0 0 0
my_stuff 0 0 0 0
upgrade 0 1 - 0
x86-class 0 5 3 4
Conversion completed. One or more failures occurred.
For errors see /tmp/jump/js2ai.log
Log file output -
# cat /tmp/jump/js2ai.log
rules: line 6: unsupported keyword: disksize
rules: line 6: unsupported keyword: installed
rules: line 8: unsupported keyword: osname
rules: line 9: unsupported keyword: hostname
rules: line 11: negation '!' not supported in manifests
rules: line 12: invalid syntax for keyword 'network' specified
upgrade: line 1: unsupported value for 'install_type' specified:
upgrade
x86-class: line 4: unsupported keyword: system_type
x86-class: line 5: ignoring eeprom 'update' setting, as this action
is not
supported
x86-class: line 6: the ZFS root pool was already created using the
'pool'
keyword, ignoring 'fdisk' definition
x86-class: line 7: unsupported keyword: partitioning
x86-class: line 8: the ZFS root pool was already created using the
'pool'
keyword, ignoring 'filesys' definition
x86-class: line 9: unsupported syntax for 'filesys' specified:
filesystems mount
points other than '/' are not supported
x86-class: line 12: unsupported keyword: cluster
x86-class: line 14: unsupported syntax for 'package' specified:
package install
from specified locations is not supported for SVR4 packages
Validation Errors:
crap1: manifest validation of /tmp/jump/AI_crap1/crap1.xml failed.
For details
see /tmp/jump/AI_crap1/crap1_validation.log
x86-class: manifest validation of
/tmp/jump/AI_x86-class/x86-class.xml failed.
For details see /tmp/jump/AI_x86-class/x86-class_validation.log
Manifest validation log -
# cat /tmp/jump/AI_x86-class/x86-class_validation.log
NOTE: The errors outputed in this file must be manually corrected
before the
resulting manifest file can be used by the Solaris automated
installer. For
information on the generated errors see installadm(1M) man page.
Once the errors have been corrected you can validate your changes via:
# js2ai -V /tmp/jump/AI_x86-class/x86-class.xml
Validation Errors:
Validation against DTD [/usr/share/auto_install/ai.dtd] failed
/tmp/jump/AI_x86-class/x86-class.xml:6:0:ERROR:VALID:DTD_CONTENT_MODEL:
Element
target content does not follow the DTD, expecting (target_device)+, got
(target_device swap dump)
/tmp/jump/AI_x86-class/x86-class.xml:17:0:ERROR:VALID:DTD_CONTENT_MODEL:
Element
zvol content does not follow the DTD, expecting (options? , size), got
/tmp/jump/AI_x86-class/x86-class.xml:20:0:ERROR:VALID:DTD_CONTENT_MODEL:
Element
zvol content does not follow the DTD, expecting (options? , size), got
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
