On 03/10/11 05:22 PM, Shawn Walker wrote:
On 03/10/11 05:15 PM, Keith Mitchell wrote:
Hi all,
Can I get a review of my fixes for the following bugs?
7025614 ai-publish-pkg stage isn't publishing a pkg
16531 pkgsend(1) to be replaced with pkgrepo(1) to create repositories
16540 Replace pkgsend(1) invocations in usr/src/pkg/Makefile with
pkgrepo(1)
Webrev:
http://cr.opensolaris.org/~kemitche/webrev.7025614/
Notes:
While converting usr/src/pkg/Makefile, I noticed that for some reason we
decide to build our packages twice: once during a "make install", and
once again when nightly processes the "p" NIGHTLY_OPTION and runs "make
pkgs". Hence, the update to the base Makefile.
I would note that the 'file://' has never been necessary with pkgrepo;
you can just use plain paths (relative or absolute). However, it is
not wrong to use it.
-Shawn
Thanks Shawn. I'll update that portion of the code to be more lenient.
As an aside, it's too bad I didn't think too look at bug 17998 first,
since that's what the root cause of 702514 really was. Still, explicitly
creating the manifest leaves this code room to manipulate the manifest
in the future if we want, so I'll leave it in.
- Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
