Jack, I will review group B.
- Dermot On 12/03/2011 03:36, Jack Schwartz wrote:
Hi everyone. Here is the first of two code review wads for the Derived Manifests project. This wad includes the AI client side support for running a script to derive manifests. A subsequent (much smaller) one coming within a few days will be for improved AI server support of default manifest management. The focus of this code review is on the following: - the Derived Manifest Module checkpoint - the aimanifest command - the Manifest Input Module (which supports aimanifest) http://cr.opensolaris.org/~schwartz/110311.1/webrev/index.html Please take a group of files and review by Weds 3/23 COB. Please let me know ASAP what you are able to review. I'll be setting up an info session for Tuesday morning from 9-10 PST to help *jumpstart* the process. (Sorry, couldn't resist) Logistic info to follow. I suggest the following groups: (A) The Derived Manifest Module usr/src/cmd/auto-install/checkpoints/dmm/Makefile usr/src/cmd/auto-install/checkpoints/dmm/__init__.py usr/src/cmd/auto-install/checkpoints/dmm/dmm.py usr/src/cmd/auto-install/checkpoints/dmm/dmm_errors.py usr/src/cmd/auto-install/checkpoints/dmm/test/Makefile usr/src/cmd/auto-install/checkpoints/dmm/test/dmm_build_test.py usr/src/cmd/auto-install/checkpoints/dmm/test/dmm_env_test.py (B) The Manifest Input Module, focus on overlay usr/src/lib/install_manifest_input/Makefile usr/src/lib/install_manifest_input/__init__.py usr/src/lib/install_manifest_input/process_dtd.py usr/src/lib/install_manifest_input/test/test_manifest_input_overlay.py usr/src/lib/install_manifest_input/test/test_process_dtd.py (C) The Manifest Input Module, the rest usr/src/lib/install_manifest_input/mim.py usr/src/lib/install_manifest_input/mim_utils.py usr/src/lib/install_manifest_input/mim_errors.py usr/src/lib/install_manifest_input/test/test_manifest_input_pathing.py usr/src/lib/install_manifest_input/test/test_manifest_input_set_get_add.py usr/src/lib/install_manifest_input/test/test_manifest_input_validate_commit.py (D) aimanifest command, AI environment prep, packaging and other files: usr/src/cmd/aimanifest/Makefile usr/src/cmd/aimanifest/aimanifest.py usr/src/Makefile.master usr/src/Targetdirs usr/src/cmd/Makefile usr/src/cmd/Makefile.cmd usr/src/cmd/Makefile.targ usr/src/cmd/auto-install/auto_install.py usr/src/cmd/auto-install/checkpoints/Makefile usr/src/cmd/auto-install/config/get_manifest usr/src/cmd/auto-install/svc/auto-installer usr/src/cmd/auto-install/svc/manifest-locator usr/src/lib/Makefile usr/src/lib/Makefile.targ usr/src/lib/install_target/Makefile usr/src/lib/install_target/shadow/Makefile usr/src/pkg/manifests/system-install-auto-install-auto-install-common.mf usr/src/pkg/manifests/system-install-auto-install.mf usr/src/tools/tests/tests.nose usr/src/cmd/rbac/Makefile usr/src/cmd/rbac/prof_attr.system%2Finstall%2Fauto-install usr/src/cmd/rbac/user_attr.system%2Finstall%2Fauto-install usr/src/cmd/auto-install/ai_get_manifest.py Thanks, Jack _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
