LGTM

- Keith

On 03/14/11 07:09 AM, Jan Damborsky wrote:
Hi Keith,

could I please ask you to review fix for following CR ?

7026873 Additional text install unit test failure after system configuration interactive tools went in

webrev:
http://cr.opensolaris.org/~dambi/cr-7026873/

Thank you,
Jan


tests accomplished:

dambi@tio:~/ws/cr-7026873/usr/src/tools/tests$ ./slim_test cmd/text-install/osol_install/text_install/test #95 Ensure that recommended_size and minimum_size are accessible after ... ok
#96 Ensure selected_disk is set properly by on_change_screen ... ok
#97 Check DiskScreen.on_change_screen when disk is None ... ok
#98 Ensure disk is copied when do_copy flag is set ... ok
#99 Ensure that DiskScreen._size_line is created and is a string after ... ok
#100 Ensure use_whole_segment is set if the disk was GPT labeled ... ok
#101 Ensure that do_copy flag is set after calls to on_activate ... ok
#102 Ensure use_whole_segment is set when the disk was initially blank ... ok
#103 Ensure new logical sizes are blanked ... ok
#104 Ensure edit field updated correctly if part_info is editable ... ok
#105 Ensure edit field updated correctly if active obj not part_field ... ok
#106 Ensure edit field not updated if no active right/left win ... ok
#107 Ensure edit field updated correctly if part_info not editable ... ok
#108 _reboot_cmds(x86) returns expected list of potential reboot commands ... ok
#109 _reboot_cmds(sparc) returns expected list of reboot commands ... ok

----------------------------------------------------------------------
Ran 15 tests in 0.255s

OK
dambi@tio:~/ws/cr-7026873/usr/src/tools/tests$


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to