William,

Just a nit since it won't really change anything but in ai_smf_service.py, if you do this:


while libaiscf.AISCF(FMRI=AI_SVC_FMRI).state.upper() not in ['DISABLED', 'OFFLINE', 'ONLINE']:
<code>

You only have to do the attribute traversal and upper() call once instead of three different times.


Otherwise, this looks fine.

-Drew




On 03/16/11 08:00, William Schumann wrote:
http://cr.opensolaris.org/~wmsch/bug-7027613/

Jeffrey Huang discovered that, upon deleting the last AI service, there are problems creating a new AI service, including the message:
  Error: Failed to restore installadm SMF service.

The code to check the state change transition of the install/server SMF service didn't consider the transition from 'maintenance' (the usual case when services are deleted) to 'online'.

Also increased the service verification timeout from 1 to 5 seconds, since it seems unnecessarily short and since increasing the timeout will not slow execution under normal circumstances.

Thank you for your attention,
William
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to