Thanks Mary. I'll remove that line before pushing.
- Keith
On 03/16/11 01:22 PM, Mary Ding wrote:
Keith:
My comments are nits.
Since you are changing ai_publish_pkg.py, you can fix the following
pep8 audit problem by getting rid of the blank line at end of file:
The original complain is as follow:
/usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/ai_publish_pkg.py:159:1:
W391 blank line at end of file
You can remove the blank line at line 180 of ai_publish_pkg.py
On 03/16/11 01:16 PM, Keith Mitchell wrote:
All,
Can I get a review of my changes for these bugs:
7027462 ai-publish-pkg checkpoint doesn't set a variant.arch
7028304 ai-publish-pkg should publish "default service name" in the
pkg metadata
Webrev:
http://cr.opensolaris.org/~kemitche/webrev.7027462
Like all of ai-publish-pkg, there are no consumers as of yet for
these changes, but ISIM will be making use of it. I'm open to
suggestions on the SVC_NAME_ATTR variable - note that this will be
difficult to change once ISIM begins consuming it, so bring up
suggestions now.
Thanks,
Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
