Hi everyone.

Here is the AI server part of the Derived Manifests project.

http://cr.opensolaris.org/~schwartz/110317.1/webrev/

Please review by Weds 3/23 COB, and please let me know you plan on reviewing.

John F., I would like you in particular to review this stuff as the changes of default manifest management are right up your alley.

If anyone wants a 1-1 to go over this stuff please let me know.

There will be one more small code review forthcoming regarding unit tests for this stuff, but I didn't want to hold this up for it. That said, I have good results having tested by running many installadm commands manually.

Read on if you're curious about what this wad brings to our product:

1) Gets rid of a hard-wired default file called default.xml. It now allows any manifest in a service's manifest pool to be designated as the default. Any criteria belonging to a manifest designated as a default are ignored. Any manifest not containing criteria and not designated the default is noted as inactive.

2) There is a new installadm export command

3) There is a new installadm update-manifest command

4) Refactored duplicate code which got the correct service directory, into a single routine.

5) Removed cruft from publish_manifest

6) All files I touched are mostly if not completely pep8 compliant. (There are some temporary XXX which mark placeholders.)

    Thanks for your time.
    Jack

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to