Hey John,

A couple of questions:

102 - I know you didn't change this line of code per this bugfix, but would it be possible that the one interface that the client brought up isn't the first one in the list?

105 - Since this is never a browse anymore, would we ever be getting more than one service returned from the find ?


-ethan


On 03/22/11 08:48, John Fischer wrote:
All,

Please review the following webrev:

    http://cr.opensolaris.org/~johnfisc/7025817-ai_sd/index.html

It resolves:

         http://monaco.us.oracle.com/detail.jsf?cr=7025817
OR    http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7025817

The failure occurs because the lookup method in the AIservice class
within ai_sd.py special cases the _default service name. The special case
was added during the webserver design project and a misunderstanding
on how the find_manifest mechanism works on the client side.  The special
case did a simple browse and assumed that the first service returned was
fine. The only problem is that the first service could be x86 or SPARC and thus potentially have the wrong architecture as well as it would not match
the service which is already providing information.

The solution is to not special case the _default service and allow the fall back mechanism within the find_manifest client side script to use the grub menu
values for host, service name and port values.

Thanks,

John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to