John,
Thanks for the comments. All taken. Webrev updated.
(Note, I'm also defining KILL to be /usr/bin/kill, and calling that
instead since shell built-in kills may vary in usage. Right now, the
default shell used is ksh93, and according to the manpage, its usage is
"kill -n signum | -s signame", but does support "kill -sigspec" for
backwards compatibility. As to not rely on this, I'm going to change
this to /usr/bin/kill to be more explicit. Let me know if anyone has
issues with this.)
thanks,
-ethan
On 03/26/11 08:12, John Fischer wrote:
Ethan,
Thanks for correcting the comments. Your changes explain what it
being done
much clearer.
All nit comments below. Therefore, if you change them I do not need
to see an
updated webrev.
Thanks,
John
===============================================================================
usr/src/cmd/installadm/check-server-setup.sh
===============================================================================
Looks good.
===============================================================================
usr/src/cmd/installadm/installadm-common.sh
===============================================================================
Nit - I would add the word "the" before entry in the following:
1071 printf " Retry after unmounting and
deleting"
1072 printf " entry form /etc/vfstab\n"
Nit - Please change "It's" to "It is" in:
1086 # It's in mnttab, but mounted somewhere
else.
===============================================================================
usr/src/cmd/installadm/setup-image.sh
===============================================================================
Looks good.
===============================================================================
usr/src/cmd/installadm/setup-service.sh
===============================================================================
Nit - I would add the word "an" before error in the following:
84 # function to return error.
Nit - I would reword the following:
123 print "Warning: The service ${name} could not be
registered"
To something like:
print "Warning: mDNS registry of service ${name} could not be
verified."
===============================================================================
usr/src/cmd/installadm/svc-install-server
===============================================================================
Looks good.
===============================================================================
On 03/25/11 08:51 PM, Ethan Quach wrote:
Can I get a review for the following bugs:
BugIDs:
----------
http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7029179
http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7027956
http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7024643
Webrev:
----------
http://cr.opensolaris.org/~equach/webrev.7029179.7027956.7024643/
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
