Hi everyone.
Here is round 2 of the Derived Manifests code review.
It is a product of integrating all code review comments, from both
server and client sides, including lots of cleanup and some bug fixes.
Thanks to Drew, Matt, Dermot, Karen and Dave for reviewing the client
side. Thanks to John for reviewing the server side.
All reviewers please double check that the code changes address what you
mentioned in your emails. Please send any comments by Friday 4/1 COB.
Client side:
Delta: http://cr.opensolaris.org/~schwartz/110329.1/webrev.cli.1.2.diff/
(No webrev vs AI-CUD gate is available.)
Server side:
Delta: http://cr.opensolaris.org/~schwartz/110329.1/webrev.srv.1.3.diff/
Vs slim_source: http://cr.opensolaris.org/~schwartz/110329.1/webrev.srv.3/
Note: Server side unit tests still need to be reviewed. Please call up
the files with their "new" link from the server side delta webrev.
Notes:
1) I have tried to apply general comments to all files, even those not
directly mentioned in the comments. (For example, to use
os.path.exists() instead of os.access().)
2) Testing is ongoing. I have unit tested pretty thoroughly on X86.
Most code is generic, but I will be re-testing the SPARC-specific bits
ASAP. QE is also testing.
3) I plan on filing one last code review of bugfixes plus any other
changes resulting from this code review, in mid April a few days before
project completion.
Thanks,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
