Hi Matt.
On 03/25/11 10:17 AM, Matt Keenan wrote:
Jack,
Some quick comments, apologies for tardiness, a little snowed under.
Thanks for your review. I appreciate your taking the time.
(A) The Derived Manifest Module
usr/src/cmd/auto-install/checkpoints/dmm/Makefile
usr/src/cmd/auto-install/checkpoints/dmm/__init__.py
usr/src/cmd/auto-install/checkpoints/dmm/dmm.py
72 : INSTALL_CONF should really be processed in /var/run not /tmp
I agree, but this change will require changing many other files, and I
don't want to take on this change as part of my project.
73 and 442
You hard code path of ai schema to validate manifest against. Two
points of note here :
- I don't think you need to do any xml validation, as
manifest-parser is used to load
the derived manifest into DOC post derivation, so it will take
care of this.
- If you still feel it's necessary can you consider validating
against the DTD that is
mentioned in the xml itself, e.g. DOCTYPE tag. This is what
manifest parser checkpoint
currently does.
The DM spec calls for validating the manifest as part of passing the DM
checkpoint, so validation will be done.
Like you, I don't like hard-wiring names. I will take the schema name
from the manifest if it is there. If the DTD name is not there, then I
will fallback to a hardwired default.
75-76 : Remove comment on Ireland transferring files, AI client will
do this
as part of transfer-files ICT
Removed.
442->467
If XML validation not being done these can be removed
See above.
Thanks again for reviewing.
Jack
cheers
Matt
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
