Karen,
Thanks for updating all the files. The updated webrev LGTM.
- Keith
On 04/ 1/11 11:12 AM, Karen Tung wrote:
On 03/31/11 14:32, Keith Mitchell wrote:
Hi Karen,
The set_lang fixes look good.
For the progress reporting, why is the estimate no longer weighted
against the default size? Additionally, this appears to be related to
7007819 - can you evaluate whether the changes fix that bug, or can
be applied to that case as well?
Thanks,
Keith
Hi Keith,
Thank you for reviewing the changes.
I restored the code that weights the size against the default size. I
previously thought it is
not needed. After our discussion, I understand why it is needed.
The changes needed for 7007819 can easily be incorporated into the
changes I am now making.
So, I have picked it up and implemented the needed changes.
The webrev is updated in place:
http://cr.opensolaris.org/~ktung/prog-lang-fix/
Thanks,
--Karen
On 03/30/11 04:56 PM, Karen Tung wrote:
Hi,
Please review my changes for the following bugs:
7032666 <http://monaco.us.oracle.com/detail.jsf?cr=7032666> Problems with
progress reporting in transfer checkpoint
5194 <http://defect.opensolaris.org/bz/show_bug.cgi?id=5194> set_lang should
skip the language selection if there's only one option
7023569 <http://monaco.us.oracle.com/detail.jsf?cr=7023569> set_lang script
can loop endlessly if English is not included in the image
webrev:
http://cr.opensolaris.org/~ktung/prog-lang-fix/
The set_lang changes have been verified to not cause regression in
any of the images
by Mary. It has also been used by the group that really wants the
fix to validate that
it solved their problem.
The progress reporting changes for the transfer checkpoint has been
tested in the text installer CUD project gate. Mary is in the progress
of running them in her DC builds to make sure they don't cause any
regression.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
