On 04/ 1/11 03:54 PM, Ethan Quach wrote:
On 04/01/11 15:46, Karen Tung wrote:
Hi Ethan,
A small comment.
boot_archive_archive.py: line 165: Since 35MB extra space added is a
fixed value now, I think it is
better to define that as a constant in this file instead of having it
buried in the code.
Sure I can do that. Can you take another look at the webrev, I've
just udpated it.
Looks all good to me now.
Thanks,
--Karen
thanks,
-ethan
Thanks,
--Karen
On 04/ 1/11 03:30 PM, Ethan Quach wrote:
Can a get a review for the following bugfix:
http://cr.opensolaris.org/~equach/webrev.6974245/
All image types in both architectures were built. All x86 images
have their writable space up'ed from ~10MB to ~25MB, which addresses
the bug. And all Sparc images have their writable space at about
~50MB. (I believe the reason Sparc images end up with a lot more
writable space is because part the sparc content ends up getting
compressed, and so ends up using less space than the initially
measured amount, thereby leaving more writable space leftover. I
think this is OK, I'd rather not use different values for the two
architectures.)
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
