Margot, Sounds good. I don't need to see another webrev.
Thanks, John On Apr 7, 2011, at 5:27 PM, Margot Hackett Miller wrote: > Hi John, > > Will move those two files up and move sbin down. > > And yes, sbin is needed as the link for sbin -> /usr/sbin > should be in the boot archive. There was a bug lately > about the link not being created. I am glad you brought > that up and I will go check with Mary/Karen to see about > that status.... Mary just emailed me that she thinks that > is fixed. > > Thanks, > Margot > > > On 04/ 7/11 05:04 PM, John Fischer wrote: >> Margot, >> >> These changes look fine. Just a couple of comments/questions. >> The other files not mentioned look good. Thanks for doing this >> work. >> >> John >> >> >> >> ================================================================================ >> >> usr/src/cmd/distro_const/manifest/boot_archive_contents_sparc.xml >> ================================================================================ >> >> 1. It is really nice when the manifest is alphabetized as it makes finding >> things easier. (extra credit) >> >> 93 <name>usr/sbin/nwamcfg</name> >> 94 <name>usr/sbin/nwamadm</name> >> >> These lines need to be moved up. >> >> 2. Does /sbin really need to be copied? If so then it would be nice if it >> were >> also moved alphabetically in the list. >> ================================================================================ >> >> usr/src/cmd/distro_const/manifest/boot_archive_contents_x86.xml >> ================================================================================ >> >> 1. Similar comment to above. >> ================================================================================ >> >> >> >> On 04/ 7/11 03:36 PM, Margot Hackett Miller wrote: >>> It is located here: >>> >>> http://cr.opensolaris.org/~margotm/slim_source >>> >>> Thanks >>> Margot >>> >>> On 04/ 7/11 11:21 AM, Margot Hackett Miller wrote: >>>> Just realized that I need to post the webrev at a place where everyone >>>> can access it. >>>> >>>> Let me do that and send another email. >>>> >>>> Thanks, >>>> Margot >>>> >>>> >>>> On 04/ 7/11 11:19 AM, Margot Hackett Miller wrote: >>>>> Please code review my changes for: >>>>> >>>>> bug 7023487 - Need to update the distro_constructor to accomodate >>>>> /sbin >>>>> becoming a link to /usr/sbin >>>>> >>>>> This bug is addresses changes needed in the install consolidation. The >>>>> other bug- >>>>> bug 7019347 "Make /sbin a link to /usr/sbin" was integrated into ON >>>>> last week, build 164. >>>>> >>>>> The webrev is at >>>>> >>>>> /net/indiana-build/data/margotm/bug7023487 >>>>> >>>>> Iso's for x86 (live-cd, text,ai) and sparc(ai,text) have been successfully >>>>> built and sparc ai,text and x86 text have been used to install a system. >>>>> >>>>> Thanks, >>>>> Margot >>>>> >>>>> >>>>> >>>>> >>>>> >>>> >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> [email protected] >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> > _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
