Those are strange. I don't see any way those could be from your changes,
though; they must be environment related. Might want to check with Evan
on them (though don't let that stop your push).
- Keith
On 04/11/11 01:02 PM, Drew Fisher wrote:
Oddly yes.
A couple of random things in js2ai failed:
======================================================================
FAIL: Test condition where we can't read profile due to permissions
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/export/home/drew/cr_7035542/usr/src/cmd/js2ai/modules/test/test_js2ai.py",
line 1325, in test_unreadable_profile
filename, False)
AssertionError: IOError not raised
======================================================================
FAIL: Test writting to a log file that we don't have perm to write to
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/export/home/drew/cr_7035542/usr/src/cmd/js2ai/modules/test/test_js2ai.py",
line 1336, in test_unwritable_logfile
self.assertRaises(IOError, js2ai.logger_setup, self.working_dir)
AssertionError: IOError not raised
----------------------------------------------------------------------
1 thing in DC:
[osol-bldx:test] > sudo nosetests test_distro_const.py
.....................E.....
======================================================================
ERROR: test to make sure the create action on the bootfs correctly errors
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/export/home/drew/cr_7035542/usr/src/cmd/distro_const/checkpoints/test/test_distro_const.py",
line 475, in test_create_root_pool
self.assertRaises(RuntimeError, dc.validate_target)
File "/usr/lib/python2.6/unittest.py", line 336, in failUnlessRaises
callableObj(*args, **kwargs)
File
"/export/home/drew/cr_7035542/proto/root_i386-nd/usr/lib/python2.6/vendor-packages/solaris_install/distro_const/__init__.py",
line 342, in validate_target
base_mountpoint = os.path.join("/", base_dataset)
File "/usr/lib/python2.6/posixpath.py", line 65, in join
if b.startswith('/'):
AttributeError: 'NoneType' object has no attribute 'startswith'
Neither of the js2ai errors have anything to do with IPS and the DC
error is fixed in cud_ti and will be fixed in the gate in a week.
You ok with me pushing?
-Drew
On 4/11/11 1:25 PM, Keith Mitchell wrote:
Seems right to me. Any issues with the unit tests?
- Keith
On 04/11/11 10:43 AM, Drew Fisher wrote:
Need a quick code review for 7035542 - Unable to run distro_const to
build ISO file, API_VERSION mismatch
http://cr.opensolaris.org/~drewfish/cr_7035542/
Keith already looked at client_api_versions.txt and found that the
changes made do not impact DC or js2ai. Testing done has been to
build x86 AI with the changed bits. No API_VERSION mismatches were
raised.
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
