Looks good, Thanks.
On 13/04/2011 18:02, Virginia Wray wrote: > Hi Darren -- > > Thanks for taking a look at this. > > See below.... > > thanks, > ginnie > > On 04/13/11 04:56 AM, Darren Kenny wrote: >> Hi Ginnie, >> >> A quick look over things and in general it looks fine. >> >> I do have a couple of questions though: >> >> - Is the assumption that the name of the DataObjectDict should be inserted >> with >> the same name as the checkpoint? > > I was following the same protocol that we used in the Transfer checkpoint. > So, if the checkpoint is instantiated with the name "XYZ" then the node > matches that. So, yes, that was what I was thinking. > > >> - When looking for the DataObjectDict in the DOC, it might be worth also >> include the class_type when searching, just to be sure you don't somehow >> pick >> up the checkpoint itself - there is no guarantee that the checkpoints >> won't >> be in the persistent tree at some point in the future... >> >> i.e. search for get_descendants(self.name, DataObjectDict) > yes. That makes sense, given the above. > > I added that in and tested it. Here is the updated webrev. > http://cr.opensolaris.org/~ginnie/7035125/ >> Thanks, >> >> Darren. >> >> On 12/04/2011 19:36, Virginia Wray wrote: >>> Hi -- >>> >>> Can I get a code review for the following bug.... >>> http://monaco.sfbay/detail.jsf?cr=7035125 >>> >>> Code review is located at: >>> http://cr.opensolaris.org/~ginnie/7035125/ >>> >>> I need to get this back into the gate by the 15th, so >>> quick turn around would be appreciated. >>> >>> thanks, >>> ginnie >>> _______________________________________________ >>> caiman-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
