Martin:
The bugs that I fixed is 7035227 and 7035542. I make a typo when I send
the code review request.
On 04/13/11 05:11 PM, Martin Widjaja wrote:
Ugh, sorry Mary. I thought I responded already, but I guess I haven't!
The test automation stuff looks good (I assume you did make sure the
Makefile still works and contains tabs instead of spaces).
The duplicate dependency looks good except you probably need to make
sure to include the bug # in the webrev/putback, ie. bug 7034542.
Below you put 7035542.
Thanks for doing this quickly,
Martin
On 4/13/2011 4:35 PM, Mary Ding wrote:
Hi:
I really need to get this done for snv_164 and can someone please
provide comments or feedback. Thanks !!!
On 04/12/11 10:04 AM, Mary Ding wrote:
Hi:
I will like to have a quick review of the following two bug fixes.
These are for snv_164 to make sure slim_source is pkglint compliance.
7035227 - Install slim_source should be pkglint-clean and strive for
pkgdepend cleanliness
7035542 - duplicate depend actions in 2 install IPS packages
http://monaco.sfbay.sun.com/detail.jsf?cr=7035277
http://monaco.sfbay.sun.com/detail.jsf?cr=7035542
This is the web rev location:
http://cr.opensolaris.org/~md5645/lint/
Testing had been done as follow:
1. After putting in the fix for 7035227, I confirmed the pkg build
will fail as follow:
==== package build errors (non-DEBUG) ====
ERROR pkglint.manifest005.2 duplicate depend actions
inpkg:/system/install/[email protected],5.11-0.164
system/install/configuration
ERROR pkglint.manifest005.2 duplicate depend actions
inpkg:/system/install/[email protected],5.11-0.164
system/install system/library/install
2. Then I put in the fix for 7035542 and confirm the pkg build will
work:
==== package build errors (non-DEBUG) ====
==== Check versioning and ABI information ====
Thanks !!!
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
