Good afternoon!
Could I please get a code review for the following bug:
http://monaco.us.oracle.com/detail.jsf?cr=7036694
The webrev is here:
http://cr.opensolaris.org/~drewfish/cr_7036694/
The crux of the problem is the custom_script checkpoint has no way of
translating the new {PKG_IMAGE_PATH} and {BOOT_ARCHIVE} replacement
strings to their respective directories. This fix allows users to
specify those replacement strings in the checkpoint args:
<checkpoint name="custom-script-one"
desc="custom script one"
mod_path="solaris_install/distro_const/checkpoints/custom_script"
checkpoint_class="CustomScript">
<args>/usr/bin/cp /etc/system {PKG_IMAGE_PATH}/myfile</args>
</checkpoint>
Also, the original replacement still works, so people can continue using:
<checkpoint name="custom-script-two"
desc="custom script two"
mod_path="solaris_install/distro_const/checkpoints/custom_script"
checkpoint_class="CustomScript">
<args>/usr/bin/cp /etc/system
%{//[@solaris_install.target.logical.Filesystem#1].mountpoint}/build_data/boot_archive/SYSTEM</args>
</checkpoint>
I prefer the first method. :)
In addition to updating the checkpoint for support of these replacement
strings, I moved to using solaris_install.Popen, and cleaned up some
extra code that served no purpose in the original.
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
