I can do that. Thanks for the review Karen!
-Drew
On 4/15/11 4:01 PM, Karen Tung wrote:
Hi Drew,
A small nit on the changes in ips.py, cpio.py and svr4.py.
You added a line to log an info level message.
Immediately afterwards, another message of level debug
will be log will will be announcing the same kind information.
I think it would be good to remove the debug level log message
so we don't have duplicates.
All other changes look good to me.
Thanks,
--Karen
On 04/15/11 10:42 AM, Drew Fisher wrote:
Good morning!
Can I please get a code review of a few DC bugs?
http://cr.opensolaris.org/~drewfish/dc_fixes/
7006574 <http://monaco.us.oracle.com/detail.jsf?cr=7006574> DC build
should complain if "none" is not a valid option for LiveCDPkgImgMod
7012568 <http://monaco.us.oracle.com/detail.jsf?cr=7012568> DC should
call InstallLogger.close()
7011261 <http://monaco.us.oracle.com/detail.jsf?cr=7011261>
distro_const shouldn't timestamp build -l output
7035137 <http://monaco.us.oracle.com/detail.jsf?cr=7035137> ba-init
complains about comments in boot_archive_contents*.xml during DC builds.
7010046 <http://monaco.us.oracle.com/detail.jsf?cr=7010046>
Checkpoints inconsistently 'announce' themselves
All transfer and DC tests run correctly. My AI ISO created from the
bits successfully booted and began installing
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
