Hi Drew, In general looking good, but I have a question about the fix in discovery.py - why are you doing the check for non-SPARC and no partitions within the for loop instead of doing it outside the loop where you could avoid looping at all.
Thanks, Darren. On 21/04/2011 16:40, Drew Fisher wrote: > Good morning! > > Could I please get a code review for the following bugs? > > 7038486 <http://monaco.us.oracle.com/detail.jsf?cr=7038486> physical > _label_disk() using incorrect logger. > 7038491 <http://monaco.us.oracle.com/detail.jsf?cr=7038491> Discovered disks > on > x86 should not have slices when there are no partitions. > 7038505 <http://monaco.us.oracle.com/detail.jsf?cr=7038505> target.dtd should > allow for <logical> to be specified without <rpool> > 7038534 <http://monaco.us.oracle.com/detail.jsf?cr=7038534> swap commands used > in TI/TD should not report stderr output > > http://cr.opensolaris.org/~drewfish/target_fixes/ > > > I verified with Matt the fixes for 7038486 and 7038534. For 7038491, I > replicated what Darren saw with a fresh VirtualBox LiveCD guest and adjusted > the > code accordingly. 7038505 goes in hand with 7038491. A fresh system won't > have > any zpools on them, but the logical node is the container for noswap and > nodump. It makes sense to allow for 0 or more zpools (instead of 1 or more > zpools). > > Thanks! > > -Drew > > > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
