While that may be true, to quote the Zen of Python, "explicit is better
than implicit." I'd prefer to see the "return None" stay.
- Keith
On 04/21/11 08:56 AM, Virginia Wray wrote:
Hi Jack --
I took a quick look and just thought I would point out the following.....
AI_Databases.py
ln 508. --- you don't need the return None. That's what is returned
by default if there is no return value.
Just a nit...
ginnie
On 04/20/11 11:19 PM, Jack Schwartz wrote:
Hi everyone.
This is sort of an FYI, sort of a code review request...
I had some significant merging to do after William's SC profiles
push. Of most significance are:
- export.py, the module implementing installadm export, merges
William's profiles code (of his export_profile.py) with my manifest
code and puts it all in one module.
- properties.py, a new module I introduced, now uses William's code
to get service information instead of mine. I replaced my
get_service_dir() function with his get_service_info(). I moved his
function out of AI_database.py.
- I have pep8-ified all python files I touched. I pylinted several,
skipping the really dirty ones because I didn't want to risk breaking
stuff.
QE has finished testing and has blessed these bits.
Since code reviews can go on forever, I've already been through
several rounds, and these changes are due to merges, I'm not asking
for a formal code review. However, if anyone has anything to say
about these bits please let me know ASAP as I plan on pushing Friday AM.
What I plan to push to slim_source, including the above, is at:
http://cr.opensolaris.org/~schwartz/110420.1/webrev-vs-slim-source/index.html
Thanks,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
